Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kustomize): Support child k8s resources inside kustomize origin annotations #5328

Merged
merged 2 commits into from
Jul 13, 2023
Merged

feat(kustomize): Support child k8s resources inside kustomize origin annotations #5328

merged 2 commits into from
Jul 13, 2023

Conversation

bo156
Copy link
Contributor

@bo156 bo156 commented Jul 12, 2023 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

In case we have a child resource created from a k8s configuration (for example - a Pod inside a Deployment resource), correctly pass the configuration to identify it inside the resource's template. After it we use this info to also get the correct information about the origin annotations of this inner resource based on the parent's origin annotations.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bo156 bo156 temporarily deployed to scan-security July 12, 2023 16:06 — with GitHub Actions Inactive
@bo156 bo156 temporarily deployed to scan-security July 12, 2023 16:16 — with GitHub Actions Inactive
@bo156 bo156 merged commit 8532a8d into main Jul 13, 2023
32 checks passed
@bo156 bo156 deleted the feature/support-parent-kustomize-annotations branch July 13, 2023 07:14
iamxiwang pushed a commit to iamxiwang/checkov that referenced this pull request Jul 13, 2023
@bo156 @actions-user
feat(kustomize): Support child k8s resources inside kustomize origin …
29d9bc0 
…annotations (bridgecrewio#5328)

* Added calculation for kustomize parent in case we need and better locate correct resource in definitions

* Mypy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@ChanochShayner ChanochShayner ChanochShayner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bo156 @gruebel @ChanochShayner