Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kustomize): Checked for existence of caller_file_path in definitions_raw #5324

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

bo156
Copy link
Contributor

@bo156 bo156 commented Jul 12, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

If self.definitions_raw does not include the calculated caller_file_path, use the saved lines on the resource instead of trying to better calculate them from the raw code

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bo156 bo156 temporarily deployed to scan-security July 12, 2023 09:36 — with GitHub Actions Inactive
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏖️

@bo156 bo156 merged commit c2c6821 into main Jul 12, 2023
41 checks passed
@bo156 bo156 deleted the bugfix/kustomize-no-definitions-raw-for-caller-file branch July 12, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants