Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): CKV_AWS_342 - managed rules have predefined actions #5322

Merged
merged 5 commits into from
Jul 12, 2023

Conversation

JamesWoolfenden
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@JamesWoolfenden JamesWoolfenden temporarily deployed to scan-security July 12, 2023 08:02 — with GitHub Actions Inactive
@gruebel gruebel temporarily deployed to scan-security July 12, 2023 09:40 — with GitHub Actions Inactive
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

@JamesWoolfenden JamesWoolfenden temporarily deployed to scan-security July 12, 2023 10:02 — with GitHub Actions Inactive
@gruebel gruebel temporarily deployed to scan-security July 12, 2023 12:41 — with GitHub Actions Inactive
@gruebel gruebel temporarily deployed to scan-security July 12, 2023 12:44 — with GitHub Actions Inactive
@gruebel gruebel merged commit 53783ef into main Jul 12, 2023
32 checks passed
@gruebel gruebel deleted the fix/CKV_AWS_342 branch July 12, 2023 15:39
iamxiwang pushed a commit to iamxiwang/checkov that referenced this pull request Jul 13, 2023
…ridgecrewio#5322)

* managed rules have predefined actions

* Update tests/terraform/checks/resource/aws/example_WAFRuleHasAnyActions/main.tf

Co-authored-by: Keith Gable <[email protected]>

* small adjustment

* fix PR comment

---------

Co-authored-by: Keith Gable <[email protected]>
Co-authored-by: Anton Grübel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CKV_AWS_342 Ensure WAF rule has any actions should not consider a managed rule group
4 participants