Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openapi): Fix ws for CKV_OPENAPI_20 #5317

Merged
merged 3 commits into from
Jul 12, 2023
Merged

fix(openapi): Fix ws for CKV_OPENAPI_20 #5317

merged 3 commits into from
Jul 12, 2023

Conversation

tsmithv11
Copy link
Collaborator

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Add ws and wss support for CKV_OPENAPI_20

@tsmithv11 tsmithv11 requested a review from gruebel July 10, 2023 15:06
@tsmithv11 tsmithv11 temporarily deployed to scan-security July 10, 2023 15:06 — with GitHub Actions Inactive
@tsmithv11 tsmithv11 mentioned this pull request Jul 10, 2023
Merged
7 tasks
@ziggythehamster
Copy link
Contributor

You should add wss to a passing example since it's expected to work

@tsmithv11 tsmithv11 temporarily deployed to scan-security July 12, 2023 04:59 — with GitHub Actions Inactive
gruebel
gruebel approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

JamesWoolfenden
JamesWoolfenden approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@JamesWoolfenden JamesWoolfenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gruebel gruebel merged commit fc591cd into main Jul 12, 2023
32 checks passed
@gruebel gruebel deleted the fix-openapi20-ws branch July 12, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWoolfenden JamesWoolfenden JamesWoolfenden approved these changes

@gruebel gruebel gruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsmithv11 @ziggythehamster @JamesWoolfenden @gruebel