fix(terraform): add module prefix to the resource ID of a module #5272
Conversation
|
|
||
| if vertex.block_type == BlockType.MODULE: | ||
| # prefix modules with 'module' to properly identify them | ||
| resource_id = f"{BlockType.MODULE}.{resource_id}" |
There was a problem hiding this comment.
how come we don't need to do it for any other resource type?
There was a problem hiding this comment.
currently none of the other non-resource blocks has a prefix, which is not so important, because they are identifiable by their block type. I did this change to align the address field to be identical to the prefix for other block types inside a module.
| @@ -316,9 +316,9 @@ def test_nested_modules_address_attribute(self): | |||
| graph_manager = TerraformGraphManager(NetworkxConnector()) | |||
| local_graph, _ = graph_manager.build_graph_from_source_directory(resources_dir, render_variables=True) | |||
| module_1 = self.get_vertex_by_name_and_type(local_graph, BlockType.MODULE, 'inner_s3_module') | |||
| assert module_1.attributes.get(CustomAttributes.TF_RESOURCE_ADDRESS) == 'module.s3_module.inner_s3_module' | |||
| assert module_1.attributes.get(CustomAttributes.TF_RESOURCE_ADDRESS) == 'module.s3_module.module.inner_s3_module' | |||
There was a problem hiding this comment.
looks like a scary change I have to say - are we sure that we handle this correctly now that we have multiple module?
There was a problem hiding this comment.
I assume so as can be seen in the expected_local_graph.json file I adjusted. multi module looks good and also resource inside that module didn't change.
|
fixed differently 🙂 |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
module.prefix to the resoruce ID of the module resources, now they are also more aligned to the address of normal resourcesChecklist: