Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): ignore local modules in CKV_TF_1 #5264

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Jun 27, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • forgot the case of local modules...

Relates #5261

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel temporarily deployed to scan-security June 27, 2023 12:56 — with GitHub Actions Inactive
@gruebel gruebel merged commit fb3aaa1 into main Jun 27, 2023
32 checks passed
@gruebel gruebel deleted the ignore-local-modules branch June 27, 2023 13:13
@richardgavel-ordinaryexperts
Copy link

richardgavel-ordinaryexperts commented Jun 27, 2023

This change doesn't account for modules that come from a module repository, which won't have a ./ ../ or a ?ref

Check: CKV_TF_1: "Ensure Terraform module sources use a commit hash"
FAILED for resource: module.networking.vpc
Error: File: /../../../modules/networking/vpc.tf:1-32
Calling File: /main.tf:11-29

	1  | module "vpc" {
	2  |   source  = "terraform-aws-modules/vpc/aws"
	3  |   version = "3.14.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants