fix(terraform_plan): add terraform plan vertices to terraform graph if not exist #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaaraVerner
had a problem deploying
to
scan-security
GitHub Actions
Failure
gruebel
reviewed
Jun 19, 2023
Comment on lines
36
to
40
| def __get_tf_vertex_idx_from_tf_plan_vertex(v): | ||
| v = self._address_to_tf_idx_and_vertex_map.get(v.attributes.get('__address__')) | ||
| if not v: | ||
| return None | ||
| return v[1] |
There was a problem hiding this comment.
I don't think this needs to be a nested method, just move it to the same level as the others.
bo156
requested changes
Jun 20, 2023
...s/terraform/runner/resources/plan_and_tf_combine_graph_with_missing_resources/source/main.tf
Show resolved
Hide resolved
YaaraVerner
had a problem deploying
to
scan-security
GitHub Actions
Failure
YaaraVerner
had a problem deploying
to
scan-security
GitHub Actions
Failure
YaaraVerner
temporarily deployed
to
scan-security
GitHub Actions
Inactive
YaaraVerner
had a problem deploying
to
scan-security
GitHub Actions
Failure
YaaraVerner
temporarily deployed
to
scan-security
GitHub Actions
Inactive
bo156
approved these changes
Jun 21, 2023
praveen-panw
pushed a commit
to praveen-panw/bc_checkov
that referenced
this pull request
Jun 21, 2023
…f not exist (bridgecrewio#5230) * add tf plan vertices to tf graph if not exist * move method to class level * fix typing * add comment for the missing resource * add typing * fix typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
added all resources that weren't found in the terraform folder (when deep-analysis enabled) to the terraform graph before scanning it in order to run graph checks over all existing resources in terraform plan files
Checklist: