Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platform(general): Implement SSO Relay State Parameter in Checkov Output Links #5217
platform(general): Implement SSO Relay State Parameter in Checkov Output Links #5217
Changes from 11 commits
b8824ca
7ee1ab7
8784004
75fa1f4
0742783
3770569
9cedfb3
4fe6670
b100695
a711320
2360b62
bcb528f
1f785e8
d2d306e
fa1bb6b
19d936c
408aa70
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikeurbanski1 any thoughts about raising an exception here or should we just log it and return the normal URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like returning the normal URL. Then at least they can go to it after signing in separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikeurbanski1 @gruebel instead of raising an exception, I could return the normal URL as follow:
With the problem that we don't trigger an exception if the BC_API_KEY is not provided. I am not sure this is better. What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't get to this code if there is no BC_API_KEY though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikeurbanski1, of course, you are correct. I committed the change.