Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sca): removing the using of the constant CHECKOV_DISPLAY_REGISTRY_URL #5204

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

itai1357
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[//]: # "
# PR Title
Be aware that we use the title to create changelog automatically and therefore only allow specific prefixes
- break: to indicate a breaking change, this supersedes any of the types
- feat: to indicate new features or checks
- fix: to indicate a bugfix or handling of edge cases of existing checks
- docs: to indicate an update to our documentation
- chore: to indicate adjustments to workflow files or dependency updates
- platform: to indicate a change needed for the platform
Additionally a scope is needs to be added to the prefix, which indicates the targeted framework, in doubt choose 'general'.
#
Allowed prefixs:

removing the using of the constant CHECKOV_DISPLAY_REGISTRY_URL

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@itai1357 itai1357 temporarily deployed to scan-security June 13, 2023 05:57 — with GitHub Actions Inactive
@itai1357 itai1357 merged commit 19a2af4 into main Jun 13, 2023
@itai1357 itai1357 deleted the itai_removing_CHECKOV_DISPLAY_REGISTRY_URL branch June 13, 2023 06:53
tsmithv11 pushed a commit that referenced this pull request Jun 13, 2023
…Y_URL (#5204)

* removing CHECKOV_DISPLAY_REGISTRY_URL

* fix tests

---------

Co-authored-by: ipeleg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants