Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): Update GCP checks for plan files #5197

Merged
merged 6 commits into from
Jun 14, 2023
Merged

fix(terraform): Update GCP checks for plan files #5197

merged 6 commits into from
Jun 14, 2023

Conversation

try-panwiac
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

CKV_GCP_38 didn't work on TF Plan files because the value was "None" but still counted as a pass.

CKV_GCP_31 didn't account for cloud-platform is converted to https://www.googleapis.com/auth/cloud-platform

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@try-panwiac try-panwiac reopened this Jun 10, 2023
@tsmithv11 tsmithv11 requested a review from gruebel June 10, 2023 06:00
@tsmithv11 tsmithv11 temporarily deployed to scan-security June 13, 2023 15:54 — with GitHub Actions Inactive
@tsmithv11 tsmithv11 requested a review from nimrodkor June 13, 2023 16:10
gruebel
gruebel approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@gruebel gruebel merged commit 6ae754a into main Jun 14, 2023
@gruebel gruebel deleted the update-gcp-plan-fps branch June 14, 2023 11:01
gruebel pushed a commit to gruebel/checkov that referenced this pull request Jun 14, 2023
@try-panwiac @tsmithv11 @actions-user
fix(terraform): Update GCP checks for plan files (bridgecrewio#5197)
90e9f0d 
* Update CKV_GCP_38 for plan files

* Update

* Update CKV_GCP_31

* Fix flakes

* Fix broken test

---------

Co-authored-by: Taylor <[email protected]>
Co-authored-by: Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimrodkor nimrodkor nimrodkor approved these changes

@gruebel gruebel gruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@try-panwiac @nimrodkor @gruebel @tsmithv11