remove list value sorting in TF and fix test

bridgecrewio · Aug 25, 2024 · d72d5af · d72d5af
1 parent 6445a34
commit d72d5af
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/checkov/terraform/modules/module_utils.py b/checkov/terraform/modules/module_utils.py
@@ -221,7 +221,6 @@ def clean_parser_types_lst(values: list[Any]) -> list[Any]:
             str_values_in_lst.append(val)
         else:
             result_values.append(val)
-    str_values_in_lst.sort()
     result_values.extend(str_values_in_lst)
     return result_values
 

diff --git a/tests/terraform/checks/data/aws/test_CloudSplainingDataExfiltration.py b/tests/terraform/checks/data/aws/test_CloudSplainingDataExfiltration.py
@@ -33,12 +33,12 @@ def test(self):
         self.assertEqual(summary["skipped"], 0)
         self.assertEqual(summary["parsing_errors"], 0)
 
+        self.assertIn('statement/[0]/actions/[1]/', report.failed_checks[0].check_result.get('evaluated_keys'))
         self.assertIn('statement/[0]/actions/[2]/', report.failed_checks[0].check_result.get('evaluated_keys'))
+        self.assertIn('statement/[0]/actions/[3]/', report.failed_checks[0].check_result.get('evaluated_keys'))
         self.assertIn('statement/[0]/actions/[4]/', report.failed_checks[0].check_result.get('evaluated_keys'))
         self.assertIn('statement/[0]/actions/[5]/', report.failed_checks[0].check_result.get('evaluated_keys'))
         self.assertIn('statement/[0]/actions/[6]/', report.failed_checks[0].check_result.get('evaluated_keys'))
-        self.assertIn('statement/[0]/actions/[7]/', report.failed_checks[0].check_result.get('evaluated_keys'))
-        self.assertIn('statement/[0]/actions/[8]/', report.failed_checks[0].check_result.get('evaluated_keys'))
 
         self.assertEqual(passing_resources, passed_check_resources)
         self.assertEqual(failing_resources, failed_check_resources)