Skip to content

Commit

Permalink
fix KubernetesDashboard false positive
Browse files Browse the repository at this point in the history
  • Loading branch information
SemProvoost committed Feb 7, 2024
1 parent 426b7c3 commit bd3322f
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 4 deletions.
2 changes: 0 additions & 2 deletions checkov/kubernetes/checks/resource/k8s/KubernetesDashboard.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ def scan_container_conf(self, metadata: Dict[str, Any], conf: Dict[str, Any]) ->
return CheckResult.FAILED
if "kubernetes-dashboard" in conf_image or "kubernetesui" in conf_image:
return CheckResult.FAILED
else:
return CheckResult.FAILED
if metadata and metadata.get("labels"):
if "app" in metadata["labels"]:
if metadata["labels"]["app"] == "kubernetes-dashboard":
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
apiVersion: v1
kind: Pod
metadata:
labels:
app: kubernetes-dashboard
spec:
containers:
- name: ccc
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
apiVersion: v1
kind: Pod
metadata:
labels:
aaa: bbb
spec:
containers:
- name: ccc
4 changes: 2 additions & 2 deletions tests/kubernetes/checks/test_KubernetesDashboard.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ def test_summary(self):
report = runner.run(root_folder=test_files_dir, runner_filter=RunnerFilter(checks=[check.id]))
summary = report.get_summary()

self.assertEqual(summary['passed'], 1)
self.assertEqual(summary['failed'], 3)
self.assertEqual(summary['passed'], 2)
self.assertEqual(summary['failed'], 4)
self.assertEqual(summary['skipped'], 0)
self.assertEqual(summary['parsing_errors'], 0)

Expand Down

0 comments on commit bd3322f

Please sign in to comment.