another fix to ecr_policy

bridgecrewio · Jul 26, 2024 · a54247a · a54247a
1 parent b8c63ee
commit a54247a
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/checkov/cloudformation/checks/resource/aws/ECRPolicy.py b/checkov/cloudformation/checks/resource/aws/ECRPolicy.py
@@ -53,9 +53,14 @@ def scan_resource_conf(self, conf: dict[str, Any]) -> CheckResult:
                         principal_block = principal_block['AWS']
                     for principal_index, principal in enumerate(principal_block):
                         if principal == "*" and not self.check_for_constrained_condition(statement):
-                            self.evaluated_keys = [
-                                f"Properties/RepositoryPolicyText/Statement/[{statement_index}]/Principal/[{principal_index}]"
-                            ]
+                            if isinstance(principal_block, list):
+                                self.evaluated_keys = [
+                                    f"Properties/RepositoryPolicyText/Statement/[{statement_index}]/Principal/[{principal_index}]"
+                                ]
+                            else:
+                                self.evaluated_keys = [
+                                    f"Properties/RepositoryPolicyText/Statement/[{statement_index}]/Principal"
+                                ]
                             return CheckResult.FAILED
         return CheckResult.PASSED