Apply suggestions from code review

bridgecrewio · Jul 29, 2024 · 297e028 · 297e028
1 parent 372ecbd
commit 297e028
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/checkov/arm/checks/resource/ACREnableZoneRedundancy.py b/checkov/arm/checks/resource/ACREnableZoneRedundancy.py
@@ -23,7 +23,7 @@ def scan_resource_conf(self, conf: dict[str, list[Any]]) -> CheckResult:
         # check registry. default=false
         properties = conf.get("properties")
         if properties and isinstance(properties, dict):
-            if properties.get("zoneRedundancy") == "disabled":
+            if properties.get("zoneRedundancy") == "Disabled":
                 return CheckResult.FAILED
         return CheckResult.PASSED
 

diff --git a/tests/arm/checks/resource/example_ACREnableZoneRedundancy/fail1.json b/tests/arm/checks/resource/example_ACREnableZoneRedundancy/fail1.json
@@ -19,7 +19,7 @@
       "properties": {
         "adminUserEnabled": "[parameters('acrAdminUserEnabled')]",
         "zoneRedundancy":
-          "disabled"
+          "Disabled"
       }
     }
   ]

diff --git a/tests/arm/checks/resource/example_ACREnableZoneRedundancy/fail2.json b/tests/arm/checks/resource/example_ACREnableZoneRedundancy/fail2.json
@@ -11,7 +11,7 @@
         "[resourceId('Microsoft.ContainerRegistry/registries/', parameters('acrName'))]"
       ],
       "properties": {
-        "zoneRedundancy": "disabled"
+        "zoneRedundancy": "Disabled"
       }
     }
   ],

diff --git a/tests/arm/checks/resource/example_ACREnableZoneRedundancy/pass.json b/tests/arm/checks/resource/example_ACREnableZoneRedundancy/pass.json
@@ -18,7 +18,7 @@
         },
         "properties": {
           "adminUserEnabled": "[parameters('acrAdminUserEnabled')]",
-          "zoneRedundancy": "enabled"
+          "zoneRedundancy": "Enabled"
         }
       }]
       }
diff --git a/tests/arm/checks/resource/example_ACREnableZoneRedundancy/pass2.json b/tests/arm/checks/resource/example_ACREnableZoneRedundancy/pass2.json
@@ -10,7 +10,7 @@
     "[resourceId('Microsoft.ContainerRegistry/registries/', parameters('acrName'))]"
   ],
   "properties": {
-    "zoneRedundancy": "enabled"
+    "zoneRedundancy": "Enabled"
   },
 
     "outputs": {