another fix to tests

bridgecrewio · Jul 24, 2024 · 0a169a2 · 0a169a2
1 parent f975119
commit 0a169a2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/tests/cloudformation/checks/resource/aws/test_IAMPermissionsManagement.py b/tests/cloudformation/checks/resource/aws/test_IAMPermissionsManagement.py
@@ -20,9 +20,9 @@ def test_summary(self):
         self.assertEqual(summary['failed'], 3)
         self.assertEqual(summary['skipped'], 0)
         self.assertEqual(summary['parsing_errors'], 0)
-        self.assertEqual(report.failed_checks[0].inspected_key_line, 13)
-        self.assertEqual(report.failed_checks[1].inspected_key_line, 28)
-        self.assertEqual(report.failed_checks[2].inspected_key_line, 43)
+        self.assertEqual(report.failed_checks[0].inspected_key_line, 12)
+        self.assertEqual(report.failed_checks[1].inspected_key_line, 27)
+        self.assertEqual(report.failed_checks[2].inspected_key_line, 42)
 
 
 if __name__ == '__main__':

diff --git a/tests/cloudformation/checks/resource/aws/test_IAMWriteAccess.py b/tests/cloudformation/checks/resource/aws/test_IAMWriteAccess.py
@@ -20,9 +20,9 @@ def test_summary(self):
         self.assertEqual(summary['failed'], 3)
         self.assertEqual(summary['skipped'], 0)
         self.assertEqual(summary['parsing_errors'], 0)
-        self.assertEqual(report.failed_checks[0].inspected_key_line, 13)
-        self.assertEqual(report.failed_checks[1].inspected_key_line, 28)
-        self.assertEqual(report.failed_checks[2].inspected_key_line, 43)
+        self.assertEqual(report.failed_checks[0].inspected_key_line, 12)
+        self.assertEqual(report.failed_checks[1].inspected_key_line, 27)
+        self.assertEqual(report.failed_checks[2].inspected_key_line, 42)
 
 
 if __name__ == '__main__':

diff --git a/tests/cloudformation/runner/resources/double_statement_cloudsplaining.yml b/tests/cloudformation/runner/resources/double_statement_cloudsplaining.yml
@@ -10,6 +10,7 @@ Resources:
         Statement:
           - Effect: Allow
             Action:
+            - 's3:GetObject'
             - 's3:PutObject'
             Resource: '*'
           - Effect: Allow

diff --git a/tests/cloudformation/runner/test_runner.py b/tests/cloudformation/runner/test_runner.py
@@ -439,7 +439,7 @@ def test_double_statement(self):
         runner = Runner(db_connector=self.db_connector())
         report = runner.run(root_folder=None, external_checks_dir=None, files=[scan_file_path],
                             runner_filter=RunnerFilter(framework=['cloudformation']))
-        self.assertEqual(len(report.failed_checks), 4)
+        self.assertEqual(len(report.failed_checks), 5)
         id_and_line = [(x.check_id, x.inspected_key_line) for x in report.failed_checks]
         self.assertIn(('CKV_AWS_107', 17), id_and_line)
         self.assertIn(('CKV_AWS_111', 14), id_and_line)