Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCBC implementation + incrBytes() for C-PCBC implementation #49

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

PCBC implementation + incrBytes() for C-PCBC implementation #49

wants to merge 6 commits into from

Conversation

0x78657671
Copy link

No description provided.

@bricke
Copy link
Owner

bricke commented Oct 31, 2022

Hi, thank you for the MR, I will test it soon

@bricke bricke self-requested a review November 2, 2022 22:03
bricke
bricke requested changes Dec 5, 2022
View reviewed changes
Copy link
Owner

@bricke bricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can you remove your .user file and add some testing for this new modes?

@0x78657671
Copy link
Author

Hi, can you remove your .user file and add some testing for this new modes?

i'm sorry I can't add those to my MR, I failed at making the test units :(
I also failed at implementing GCM so I started other projects more hardware oriented

@bricke
Copy link
Owner

bricke commented Dec 5, 2022

I can try making them myself

@0x78657671
Copy link
Author

That would be perfect, block cipher mode implementation is easier than copying test units coding standarts
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricke bricke bricke requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x78657671 @bricke