-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move project metadata to pyproject.toml, clean-up #883
Conversation
Thank you for the contribution. I'll try to check it out this week. Certainly looks like good work. I've only come across |
Yes, pyproject.toml is here to stay as a configuration file for a wide range of Python projects. |
dac9b84
to
d4b7d05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'd rather wait until the next release is out to merge this. Unless @vermeeren would like to merge this and see how it impact the release process.
I'm not sure when @vermeeren might have time to attempt a release.
Adjust the Sphinx constraint in pyproject.toml. Conflicts: requirements/production.txt setup.py
# Conflicts: # .github/workflows/documentation.yml # .github/workflows/lint.yml # .github/workflows/unit_tests.yml # breathe/__init__.py # documentation/environment.yaml # documentation/source/conf.py # pyproject.toml # tests/warnings/source/conf.py
There are perhaps too many changes here, but here's a summary of the main items:
Transferring metadata from setup.py to pyproject.toml is nearly 1:1 with a few changes:
requirements/production.txt
to the dependencies section. These are now installed viapip install .
, along with the package.pip install .[lint]
. Perhaps others should be created, e.g. "doc"?Other changes:
.flake8
configurationbreathe.__init__.__version__
, soversion-check
is unnecessarypython3 -m build
(docs) instead of directly invokingsetup.py