Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move union directive to be class-like #799

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakobandersen
Copy link
Collaborator

@jakobandersen jakobandersen commented Feb 6, 2022

The union directive is currently classified as an "item", similar to typedefs, enums, and enumerators. However, formally it is a class type (https://en.cppreference.com/w/cpp/language/type), and in terms of documentation I think it should be handled as classes are. See also #698.

The HTML for the Breathe docs are unaffected by this change.

Fixes #793?

TODOs:

  • More extensive testing. Directive refactoring #698 mentions something about namespacing that I don't remember the details of, but should be double checked.'
  • Docugmentation update?
  • Changelog entry.

@dmg0345
Copy link

dmg0345 commented Jun 28, 2022

Any chance this could be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doxygenunion does not work as intended
2 participants