Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flay context menu test on macOS #26501

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

simonhong
Copy link
Member

issue: brave/brave-browser#42232

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@cdesouza-chromium
Copy link
Collaborator

Is this test going to just be permanently disabled for macOS then?

@simonhong
Copy link
Member Author

Is this test going to just be permanently disabled for macOS then?

I think disabling on macOS is fine as it's cross platform feature.
We could investigate later. This PR is for unlocking other PR merging.
Or, should we revert original PR?

@simonhong simonhong merged commit 2f34c66 into master Nov 12, 2024
18 checks passed
@simonhong simonhong deleted the disable_flaky_context_menu_test_onMac branch November 12, 2024 13:17
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 12, 2024
@cdesouza-chromium
Copy link
Collaborator

Is this test going to just be permanently disabled for macOS then?

I think disabling on macOS is fine as it's cross platform feature. We could investigate later. This PR is for unlocking other PR merging. Or, should we revert original PR?

Would you mind creating a ticket then for it? I understand you are swamped lately, but having a ticket might help revisiting it.

@brave-builds
Copy link
Collaborator

Released in v1.75.13

@wknapik
Copy link
Collaborator

wknapik commented Nov 13, 2024

@simonhong should brave/brave-browser#42232 be resolved?

@simonhong
Copy link
Member Author

Is this test going to just be permanently disabled for macOS then?

I think disabling on macOS is fine as it's cross platform feature. We could investigate later. This PR is for unlocking other PR merging. Or, should we revert original PR?

Would you mind creating a ticket then for it? I understand you are swamped lately, but having a ticket might help revisiting it.

Yup, filed brave/brave-browser#42252

@simonhong
Copy link
Member Author

@simonhong should brave/brave-browser#42232 be resolved?

Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants