-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in AI Chat when conversation is unassociated from page content #26495
Conversation
aec6cc8
to
849427b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
…ion is not associated
849427b
to
699173e
Compare
Released in v1.75.12 |
…ent (#26495) * AIChat ConversationHandler remove NOTREACHED_IN_MIGRATION * ConversationHandler notifies AssociatedContentDelegate when conversation is not associated
…ent (#26495) * AIChat ConversationHandler remove NOTREACHED_IN_MIGRATION * ConversationHandler notifies AssociatedContentDelegate when conversation is not associated
Verification PASSED on
Using
Using the same STR/Cases outlined via brave/brave-browser#42092 (comment) which were used above to reproduce the two crashes, ensured that Verification PASSED on
Using
Using the same STR/Cases outlined via brave/brave-browser#42092 (comment) which were used above to reproduce the two crashes, ensured that |
The associated content wasn't notified in all cases that the conversation was no longer associated with it and would not be notified of destruction. It kept a reference to the conversation and used it after destruction.
Fix brave/brave-browser#42091
Fix brave/brave-browser#42092
Also removes a
NOTREACHED_IN_MIGRATION
from the same file.Fix brave/brave-browser#42089
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
STR in brave/brave-browser#42092