Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted ntp widget prefs migration code #26473

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 11, 2024

fix brave/brave-browser#42205

Delete ntp widget related migration code.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

n/a

@simonhong simonhong self-assigned this Nov 11, 2024
@simonhong simonhong marked this pull request as ready for review November 11, 2024 14:52
@simonhong simonhong requested review from a team as code owners November 11, 2024 14:52
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... good stuff.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ from me (I made the migration I believe). Thanks @simonhong! 😄👍

@simonhong
Copy link
Member Author

@brave/sources-gni-reviewers Kindly ping :)

@simonhong simonhong merged commit 694a95d into master Nov 13, 2024
18 checks passed
@simonhong simonhong deleted the delete_deprecated_ntp_widget_migration branch November 13, 2024 12:08
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 13, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete ntp widget migration code
5 participants