Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch staged entries from Brave Search before opt-in to Leo (uplift to 1.73.x) #26468

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fetch staged entries from Brave Search before opt-in to Leo (uplift to 1.73.x) #26468

merged 1 commit into from
Nov 11, 2024

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Nov 11, 2024 •
edited by kjozwiak
Loading

Uplift of #26424
Resolves brave/brave-browser#42112

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@yrliou
Merge pull request #26424 from brave/fix_opt_in_case
397eeaa 
Fetch staged entries from Brave Search before opt-in to Leo
@yrliou yrliou added this to the 1.73.x - Release milestone Nov 11, 2024
@yrliou yrliou self-assigned this Nov 11, 2024
@yrliou yrliou requested a review from a team as a code owner November 11, 2024 06:52
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 11, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.73.x approved 👍 QA has verified the PR on Nightly using 1.75.x as per #26424 (comment).

@kjozwiak kjozwiak merged commit 9b43ec8 into 1.73.x Nov 11, 2024
16 checks passed
@kjozwiak kjozwiak deleted the pr26424_fix_opt_in_case_1.73.x branch November 11, 2024 20:32
@brave-builds
Copy link
Collaborator

Released in v1.73.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@yrliou yrliou

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@yrliou @brave-builds @kjozwiak