Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted deprecated prefs from private NTP #26466

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 11, 2024

fix brave/brave-browser#23493

It's time to delete them as DDG toggle button in private NTP was deleted 2y ago.

Below two prefs and related codes are deleted.

inline constexpr char kUseAlternativePrivateSearchEngineProvider[] =
    "brave.use_alternate_private_search_engine";
inline constexpr char kShowAlternativePrivateSearchEngineProviderToggle[] =
    "brave.show_alternate_private_search_engine_toggle";

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

n/a

@simonhong simonhong self-assigned this Nov 11, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 11, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

fix brave/brave-browser#23493

It's time to delete them as DDG toggle button in private NTP was
deleted 2y ago.
@simonhong simonhong force-pushed the cleanup_deprecated_private_ntp_api branch from d7b9fa1 to 6ccf792 Compare November 11, 2024 05:21
@simonhong simonhong marked this pull request as ready for review November 11, 2024 06:32
@simonhong simonhong requested a review from a team as a code owner November 11, 2024 06:32
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did some awesome weeding here. LGTM

@simonhong simonhong merged commit 5bf7c0a into master Nov 11, 2024
17 checks passed
@simonhong simonhong deleted the cleanup_deprecated_private_ntp_api branch November 11, 2024 12:37
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 11, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.10

@fallaciousreasoning
Copy link
Contributor

Great work @simonhong !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup ddg toggle handler from BraveNewTabMessageHandler
4 participants