Simplify gn handlebars patching
#26365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns our own handlebars file closer to the upstream one, so it is easier to compare changes, and therefore to fix recent additions.
bridiver
reviewed
Nov 4, 2024
| -# Copyright 2023 The Chromium Authors | ||
| -# Use of this source code is governed by a BSD-style license that can be | ||
| -# found in the LICENSE file. | ||
| +# Copyright (c) 2024 The Brave Authors. All rights reserved. |
There was a problem hiding this comment.
We probably need to keep the original copyright here?
This change contains the handlebars changes we apply to our own handlebars file. This commit also adds a patch that can be used to update the handlebar files, based on new upstream additions.
cdesouza-chromium
force-pushed
the
simplify-gn-handlebars-patching
branch
from
c991329
to
57d9a2e
Compare
|
Created a follow up issue: |
bridiver
approved these changes
Nov 6, 2024
cdesouza-chromium
added a commit
that referenced
this pull request
Nov 6, 2024
During a recent PR to fix the rust handlebars for gn files, there was a change to the copyright notice, and then this got overlooked, with the new handlebars used to regenerate all `BUILD.gn` files with the new notice. This has rendered a dirty `gnrt` run. This PR adds the updated files. This PR also moves the file to its correct place. [1]#26365
24 tasks
cdesouza-chromium
added a commit
that referenced
this pull request
Nov 7, 2024
During a recent PR to fix the rust handlebars for gn files, there was a change to the copyright notice, and then this got overlooked, with the new handlebars used to regenerate all `BUILD.gn` files with the new notice. This has rendered a dirty `gnrt` run. This PR adds the updated files. This PR also moves the file to its correct place. [1]#26365
|
Released in v1.75.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reformats our handlebars template, to make it easier to see what exactly we are changing compared with the upstream file. It also adds a patch file that can be used to patch an upstream copied content.
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: