Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Re-add tab event handlers for metadata fetch #25748

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

kylehickinson
Copy link
Collaborator

This partially reverts a change in #24376 which removed a set of TabEventHandler's

Resolves brave/brave-browser#41208

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This partially reverts a change in #24376 which removed a set of TabEventHandler's
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Oct 1, 2024
@kylehickinson kylehickinson self-assigned this Oct 1, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner October 1, 2024 16:08
@kylehickinson kylehickinson added the CI/skip-macos-x64 Do not run CI builds for macOS x64 label Oct 1, 2024
@kylehickinson kylehickinson merged commit 6b2686d into master Oct 1, 2024
18 checks passed
@kylehickinson kylehickinson deleted the ios-tab-metadata-regression branch October 1, 2024 18:05
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Oct 1, 2024
brave-builds added a commit that referenced this pull request Oct 1, 2024
@hffvld
Copy link
Collaborator

hffvld commented Oct 2, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7
Brave build: 1.72 (55)
BraveCore: 1.72.55 (129.0.6668.89)

STEPS:

  1. New Install
  2. Enable Brave News
  3. Navigate to https://en.m.wikipedia.org/wiki/Main_Page or any other article
  4. Scroll down the article halfway
  5. Open the hamburger menu > Verify that Add Source to Brave News is here
  6. Tap Add Source to Brave News > Tap Add
  7. Go to Brave News settings > Following > Verify that Wikipedia is added as a source of news

ACTUAL RESULTS:

  • Verified that Add Source to Brave News is present in the Hamburger menu
  • Verified that the source can be added to the Following sources in Brave News

1 2 3
1 2 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Add Source to Brave News' missing from hamburger menu for articles
3 participants