Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crash while saving file using an extension. #25702

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented Sep 24, 2024

Fixes brave/brave-browser#41179

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@iefremov iefremov requested a review from a team as a code owner September 24, 2024 13:18
@iefremov iefremov merged commit c69ab5e into master Sep 24, 2024
20 checks passed
@iefremov iefremov deleted the ie_checktitle branch September 24, 2024 15:36
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 24, 2024
brave-builds added a commit that referenced this pull request Sep 24, 2024
brave-builds added a commit that referenced this pull request Sep 24, 2024
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.72.36 Chromium: 129.0.6668.59 (Official Build) nightly (64-bit)
-- | --
Revision | 51674f94510fc84f3c951f68c4d169bbc31960c2
OS | Windows 11 Version 23H2 (Build 22631.4169)

Reproduced the original issue using 1.72.34 Chromium: 129.0.6668.59 with the STR/Cases outlined via brave/brave-browser#41179 (comment) as per the following:

reproducedCrash.mp4

Using the same STR/Cases as mentioned above, ensured that Brave wasn't crashing when using the SingleFile extension as per the following:

workingExtension.mp4

kjozwiak pushed a commit that referenced this pull request Sep 25, 2024
kjozwiak pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave crashes when downloading something with various extensions
3 participants