Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong region list name mapping #25701

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Sep 24, 2024

f/u PR for #25596
fix brave/brave-browser#41227

it should be "eu-en".

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Live in england(london) to get current timezone as eu-en
  2. Launch with clean profile
  3. Setup VPN as purchased
  4. No crash!

@simonhong simonhong self-assigned this Sep 24, 2024
f/u PR for #25596

it should be "eu-en".
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong merged commit af8a8e6 into master Sep 24, 2024
17 checks passed
@simonhong simonhong deleted the fix_wrong_region_list_mapping branch September 24, 2024 15:05
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 24, 2024
brave-builds added a commit that referenced this pull request Sep 24, 2024
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.72.37 Chromium: 129.0.6668.59 (Official Build) nightly (64-bit)
-- | --
Revision | c0271c2db30a45dc80f44487ee2e84212cfef92e
OS | Windows 11 Version 23H2 (Build 22631.4169)

Pre-requisite: Changed the region/time zone to London in Windows settings

  1. Installed 1.72.37
  2. launched Brave
  3. logged into account.bravesoftware.com with existing VPN subscription credentials
  4. clicked Refresh Firewall + VPN button
  5. verified Brave VPN credentials are now loaded on this device message is shown
  6. clicked VPN button
  7. toggled on/off to enable VPN in the VPN panel
  8. opened whatismyipaddress.com in a new tab
  • Confirmed no crash occurred.
  • Confirmed VPN server is auto-selected to England
  • Confirmed successfully enabled/disabled VPN
  • Confirmed correct region is shown in whatismyipaddress.com page
example example example example example example
image image image image image image

kjozwiak pushed a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashed when vpn credential loaded
3 participants