-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse procedural_filters.ts for ios #25694
base: master
Are you sure you want to change the base?
Conversation
A Storybook has been deployed to preview UI for the latest push |
6e39d70
to
7a28277
Compare
7a28277
to
032dbe9
Compare
[puLL-Merge] - brave/brave-core@25694 DescriptionThis PR introduces changes to the cosmetic filters functionality in the Brave browser, particularly for iOS. It moves the content cosmetic filters script from iOS-specific files to a shared location, making it available for both iOS and non-iOS platforms. The PR also updates the build configurations and script handling to accommodate these changes. ChangesChanges
Possible Issues
Security HotspotsNo significant security hotspots were identified in this change. However, as with any change involving content scripts and filters, thorough testing should be done to ensure that the new implementation doesn't introduce any vulnerabilities or unintended behavior in content blocking. |
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: