Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Render widgets correctly in tinted mode #25693

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

kylehickinson
Copy link
Collaborator

Resolves brave/brave-browser#41178

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Sep 23, 2024
@kylehickinson kylehickinson self-assigned this Sep 23, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner September 23, 2024 14:38
@kylehickinson kylehickinson merged commit 8316360 into master Sep 23, 2024
18 checks passed
@kylehickinson kylehickinson deleted the ios-tinted-widgets branch September 23, 2024 16:42
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 23, 2024
brave-builds added a commit that referenced this pull request Sep 23, 2024
brave-builds added a commit that referenced this pull request Sep 23, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 25, 2024

Verified on the following device(s):

  • iPhone 12 running iOS 18.0 using version 1.72 (35)
  • iPhone XR running iOS 17.7 using version 1.72 (49)
  • iPad (7th Gen) running iPadOS 17.5.1 using version 1.72 (49)
  • iPhone X running iOS 16.7.8 using version 1.72 (49)

  • Ensured that tinted icons are rendered correctly and light / dark mode has not regressed.
  • Ensured that small and large icons are rendered correctly.
  • Ensured that icons and widgets have not regressed on iOS/iPadOS 17 for light/dark mode.
  • Ensured light and dark mode has not regressed on iOS 16.

iOS 18

example example example example
IMG_7493 IMG_7498 IMG_7490 IMG_7491

iOS 17 / iPadOS 17

example example
IMG_0400 2 IMG_0401 2
IMG_0403 2 IMG_0402 2
IMG_1642 IMG_1643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tinted mode not working for some Brave widgets [iOS 18]
4 participants