-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable cosmetic filtering on Speedreader pages #25692
base: master
Are you sure you want to change the base?
Conversation
25de121
to
107800e
Compare
if I understand correctly, we only disable CF, not all shields on distilled pages, right? So this is something different from what the task requires. So we'd better to either modify task and rename PR ("Disable cosmetic filtering on speedreader pages") or properly disable shields |
@ShivanKaul Yes, you are right. The actual disabling of shields for the specified tab will require quite a lot of changes, because now the settings work at the ContentSettings level. In general, this could be useful, but so far there has been no need to disable shields for a specific tab (AFAIK). Disabling CF is enough to solve problems with the reading mode I would even prefer not to disable the shields button. |
107800e
to
d368c1f
Compare
@boocmp @iefremov We do have issues with Speedreader + network blocking too: https://bravesoftware.slack.com/archives/CLX7EV42Z/p1726603890011589?thread_ts=1726595972.638809&cid=CLX7EV42Z |
Spoke with @boocmp and I understand now that network blocking is not relevant here, at least for the issue I mentioned. Let's go with just CF disabling. |
Resolves brave/brave-browser#40642
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: