Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cosmetic filtering on Speedreader pages #25692

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented Sep 23, 2024

Resolves brave/brave-browser#40642

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@iefremov
Copy link
Contributor

iefremov commented Sep 23, 2024

if I understand correctly, we only disable CF, not all shields on distilled pages, right? So this is something different from what the task requires. So we'd better to either modify task and rename PR ("Disable cosmetic filtering on speedreader pages") or properly disable shields

@boocmp
Copy link
Contributor Author

boocmp commented Sep 24, 2024

@ShivanKaul Yes, you are right. The actual disabling of shields for the specified tab will require quite a lot of changes, because now the settings work at the ContentSettings level. In general, this could be useful, but so far there has been no need to disable shields for a specific tab (AFAIK). Disabling CF is enough to solve problems with the reading mode I would even prefer not to disable the shields button.

@ShivanKaul
Copy link
Collaborator

@ShivanKaul
Copy link
Collaborator

Spoke with @boocmp and I understand now that network blocking is not relevant here, at least for the issue I mentioned. Let's go with just CF disabling.

@ShivanKaul ShivanKaul changed the title Disable Shields on Speedreader pages Disable cosmetic filtering on Speedreader pages Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable cosmetic filtering on Speedreader pages
3 participants