Rewards check includes

[bridiver]

Resolves brave/brave-browser#10618

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[zenparsing]

This is great - thanks!

[zenparsing]

Up to you, but since this is only used within the tab helper, it could be a nested class or be given a more specific name.

[bridiver]

I wasn't really sure what to call it, but I'm open to suggestions

[goodov]

nit: consider fixing these paths to be local in all new targets you introduce in this PR:

    "rewards_service_factory.h",
    "rewards_tab_helper.h",

[bridiver]

oops, yep, copy-pasted the list and forgot to remove the full paths

[goodov]

const all constructor-initialized pointers to trigger compile errors if initialization is missing.

[goodov]

there's ui/webui/brave_rewards dir. Would be nice to move this into it.

[bridiver]

trying to avoid any changes that aren't necessary here because it already touches a lot of stuff

[github-actions]

[puLL-Merge] - brave/brave-core@25685

Here's my review of the pull request:

Description

This PR refactors the Brave Rewards service implementation to reduce dependencies and improve modularity. The main changes include:

1. Decoupling RewardsServiceImpl from Profile, using more specific dependencies instead.
2. Restructuring the build files to separate the Brave Rewards implementation from its interfaces.
3. Cleaning up include statements and removing unused dependencies.
4. Adjusting tests to work with the new RewardsServiceImpl constructor.

Changes

Changes

browser/brave_rewards/BUILD.gn

• Added new source sets for brave_rewards and brave_rewards_impl.
• Moved sources from sources.gni into these new source sets.
• Added conditional compilation for Greaselion and extensions support.

browser/brave_rewards/rewards_service_factory.cc

• Updated RewardsServiceImpl constructor call to use specific services instead of Profile.
• Added FaviconService and BitmapFetcherService as dependencies.

browser/brave_rewards/rewards_tab_helper.cc and .h

• Introduced BraveBrowserListObserver to handle browser list observations.

browser/greaselion/BUILD.gn

• Created a new BUILD.gn file for the Greaselion component.

browser/sources.gni

• Removed references to brave_rewards_sources and greaselion_sources.
• Added reference to new Brave Rewards Android sources.

browser/ui/BUILD.gn

• Created a new source set for brave_rewards_source.

components/brave_rewards/browser/BUILD.gn

• Updated dependencies and removed unnecessary public_deps.

components/brave_rewards/browser/rewards_service_impl.cc and .h

• Refactored constructor to take specific services instead of Profile.
• Replaced profile_ member with individual service members.
• Updated methods to use the new service members instead of accessing through profile_.

components/brave_rewards/browser/rewards_service_impl_unittest.cc and rewards_service_impl_jp_unittest.cc

• Updated test setup to use the new RewardsServiceImpl constructor.

Possible Issues

• The refactoring might have introduced subtle changes in behavior due to the different way services are now accessed. Thorough testing of all Brave Rewards functionality is recommended.

Security Hotspots

No significant security issues were identified in this change.

Overall, this refactoring appears to be a positive change that improves the modularity and testability of the Brave Rewards service. It reduces coupling with the Profile class and makes dependencies more explicit, which should make the code easier to maintain and extend in the future.

[fmarier]

browser/tor/test/BUILD.gn change 👍