Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Own target for brave/browser/ai_chat, brave/browser/skus, brave/brows… #25681

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Sep 20, 2024

…er/misc_metrics

A few files are still in brave/browser/misc_metrics/sources.gni because they are using files in chrome/browser target.

Resolves brave/brave-browser#41177

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@yrliou yrliou self-assigned this Sep 20, 2024
@yrliou yrliou requested review from a team as code owners September 20, 2024 22:13
@yrliou yrliou force-pushed the aichat-services-gni-fix-rebase branch from 1e29672 to fa6b72d Compare September 20, 2024 22:34
}

static_library("misc_metrics") {
sources = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have visibility set so people depend on the correct target above. Also I think target names misc_metrics for the public one and misc_metrics_impl for this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 43ac573, please check, thanks.

@yrliou yrliou force-pushed the aichat-services-gni-fix-rebase branch from fa6b72d to 43ac573 Compare September 20, 2024 23:18
@yrliou yrliou enabled auto-merge (squash) September 21, 2024 00:10
@yrliou yrliou merged commit 1ac409f into master Sep 21, 2024
17 checks passed
@yrliou yrliou deleted the aichat-services-gni-fix-rebase branch September 21, 2024 00:57
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brave/browser/ai_chat, brave/browser/skus, brave/browser/misc_metrics should have it's own target
2 participants