-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): add squid to cross-chain swap providers #25676
Conversation
components/brave_wallet_ui/components/extension/confirm-transaction-panel/swap.tsx
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/page/screens/swap/components/swap/routes/route_option.tsx
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/page/screens/swap/components/swap/routes/route_option.tsx
Outdated
Show resolved
Hide resolved
components/brave_wallet_ui/page/screens/swap/components/swap/routes/route_option.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS++
iOS build failed due to formatting errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wallet core lgtm
[puLL-Merge] - brave/brave-core@25676 DescriptionThis pull request introduces support for the Squid swap provider in the Brave Wallet. It adds new functionality to handle Squid quotes and transactions, updates the UI to include Squid as a swap option, and modifies existing components to integrate Squid into the swap flow. ChangesChanges
Possible Issues
Security Hotspots
This PR significantly expands the swap capabilities of the Brave Wallet by adding support for the Squid protocol. It requires careful testing to ensure compatibility with existing swap providers and to verify the correctness of Squid-specific operations. |
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Released in v1.73.11 |
Resolves brave/brave-browser#41049
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
User should be able to see a quote from Squid Router, create a transaction, and confirm it on the blockchain.