Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filecoin-cxx deps, mainly multihash reland #25666

Merged
merged 8 commits into from
Sep 20, 2024
Merged

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Sep 19, 2024

This change is a first pass in getting the dependecies for filecoin-cxx updated, to eventually be able to drop the unmaintained crate proc-macro-error.

This change updates multihash to v0.16.3->v0.18.1. In a follow up PR, the goal will be to deploy v0.19.1, which drops the unwanted crate as a transient dependency.

Reland of #25553

Resolves brave/brave-browser#40947

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

rillian and others added 4 commits September 19, 2024 16:23
This change is a first pass in getting the dependecies for
`filecoin-cxx` updated, to eventually be able to drop the unmaintained
crate `proc-macro-error`.

This change updates `multihash` to `v0.16.3`->`v0.18.1`. In a follow up
PR, the goal will be to deploy `v0.19.1`, which drops the unwanted crate
as a transient dependency.
@bridiver bridiver requested review from a team as code owners September 19, 2024 23:48
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Sep 19, 2024
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script/brave_license_helper.py change 👍

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bridiver bridiver changed the title Update filecoin-cxx deps, mainly multihash Update filecoin-cxx deps, mainly multihash reland Sep 20, 2024
Base automatically changed from curve25519-dalek-4.1.3-reland to master September 20, 2024 21:16
@bridiver bridiver requested a review from a team as a code owner September 20, 2024 21:16
@bridiver bridiver merged commit cf10198 into master Sep 20, 2024
15 checks passed
@bridiver bridiver deleted the multihash-reland branch September 20, 2024 23:48
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit finding: https://rustsec.org/advisories/RUSTSEC-2024-0370
7 participants