-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update filecoin-cxx
deps, mainly multihash
reland
#25666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update curve25519-dalek to v4.1.3
This change is a first pass in getting the dependecies for `filecoin-cxx` updated, to eventually be able to drop the unmaintained crate `proc-macro-error`. This change updates `multihash` to `v0.16.3`->`v0.18.1`. In a follow up PR, the goal will be to deploy `v0.19.1`, which drops the unwanted crate as a transient dependency.
github-actions
bot
added
the
CI/run-audit-deps
Check for known npm/cargo vulnerabilities (audit_deps)
label
Sep 19, 2024
fmarier
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script/brave_license_helper.py
change 👍
mkarolin
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
bridiver
changed the title
Update
Update Sep 20, 2024
filecoin-cxx
deps, mainly multihash
filecoin-cxx
deps, mainly multihash
reland
antonok-edm
approved these changes
Sep 20, 2024
darkdh
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a first pass in getting the dependecies for
filecoin-cxx
updated, to eventually be able to drop the unmaintained crateproc-macro-error
.This change updates
multihash
tov0.16.3
->v0.18.1
. In a follow up PR, the goal will be to deployv0.19.1
, which drops the unwanted crate as a transient dependency.Reland of #25553
Resolves brave/brave-browser#40947
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: