Upgrade from Chromium 130 to Chromium 131. #25662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/run-network-audit
mkarolin
force-pushed
the
cr131
branch
2 times, most recently
from
e799214
to
4e38208
Compare
cdesouza-chromium
force-pushed
the
cr131
branch
2 times, most recently
from
22b70f0
to
afe0344
Compare
|
A Storybook has been deployed to preview UI for the latest push |
cdesouza-chromium
force-pushed
the
cr131
branch
6 times, most recently
from
44666c9
to
9fb89a2
Compare
mkarolin
commented
Oct 1, 2024
patches/ui-webui-resources-cr_elements-cr_icon-cr_icon.ts.patch
Outdated
Show resolved
Hide resolved
cdesouza-chromium
force-pushed
the
cr131
branch
4 times, most recently
from
c42219a
to
735f435
Compare
cdesouza-chromium
force-pushed
the
cr131
branch
3 times, most recently
from
2352200
to
dc0847e
Compare
Chromium implementation of DeriveKeyScrypt has a CHECK in it that would crash the browser if the underlying BoringSSL function failed. We use this code from HDKey::GenerateFromV3UTC where the data is retrieved from JSON and can't be guaranteed to always be valid. In order not to crash, added DeriveKeyScrypt implementation without the CHECK and also changed our DeriveKeyPbkdf2HmacSha256 implementation to no use CHECK either. Additionally, moved HDKey::GenerateFromV3UTC code to use DeriveKeyScrypt and DeriveKeyPbkdf2HmacSha256 directly instead of using SymmetricKey wrappers that are being deprecated. Chromium change: https://chromium.googlesource.com/chromium/src/+/4046edfc95050796d4a1bc54cdba6942257b6f38 commit 4046edfc95050796d4a1bc54cdba6942257b6f38 Author: Elly <[email protected]> Date: Thu Oct 10 20:51:36 2024 +0000 crypto: add kdf interface Right now, //crypto supports KDFs via two interfaces: * PBKDF2-HMAC-SHA1 and Scrypt on crypto::SymmetricKey * HKDF-SHA256 via free functions This change: * Adds crypto::SubtlePassKey for access to subtle crypto primitives * Creates a new KDF interface * Moves the PBKDF2-HMAC-SHA1 and Scrypt implementations to that interface, and guards them with SubtlePassKeys * Adds new unit tests covering those KDFs * Deprecates SymmetricKey * Deletes many of the unit tests for SymmetricKey, which either covered logic which is now moved to the KDF implementations (and is covered by their tests) or tested key lengths we don't allow in production. Bug: 369653192, 369649346
Chromium change: https://source.chromium.org/chromium/chromium/src/+/65eee63c0e75ebd343c409a7c14addb00ca4b6dd [Tab Model] Deprecate tab_groups package Merge the tab_groups/ package into tabmodel/. The two packages have significant overlap and should really have a lot of their logic merged anyway. This allows us to package protect TabGroupModelFilterInternal and make destroy method package private as well. Fixed: 372068933
Chromium change: https://source.chromium.org/chromium/chromium/src/+/db64d75a6190bc6f3b1014ba0462f391b2b35135 [bookmarks] Fetch favicons from google if they're not found locally Bug: 368130323,368683034
Chromium change: https://source.chromium.org/chromium/chromium/src/+/3d4bd05bd10bced9902f9dd06cf1ad19389c6ba2 Add EdgeToEdgeStateProvider to replace usage of #setDecorFitsSystemWindows Bug: 369841366
Chromium change: https://source.chromium.org/chromium/chromium/src/+/d15dc67556629c7f39c418cd6b81e03c48eee30c [UPMAccessLossWarning] Add export flow final step metric The new metric tracks the last step that the user took as part of the export flow. Change-Id: I5db5c776b476c49160b39e3f27ee0a50bd8a4d41
Follow up issues exist/created: * brave/brave-browser#29631 * brave/brave-browser#41674
Chromium's last id went up again and was conflicting with our ids (specifically on MacOS causing a crash constructing Help menu).
As a code review suggestion, split the `if` statement for `doesProcessSuggestion` for better logic readability.`
Page load failes bacause `br_shared_vars.css.js` resource not available for android and ios. Chromium change: https://chromium.googlesource.com/chromium/src/+/27af2840dc73c5e5a0cb13e368b2a44820ba7431 FlagsUI: Leverage cr-button instead of a custom button. As part of this change, several changes are needed to make cr_button.ts available on Android and iOS builds. Bug: 40246381
cdesouza-chromium
force-pushed
the
cr131
branch
from
f9076ef
to
386e88a
Compare
|
Going to force merge here - we have enough approvals 😄 (was only waiting for one more). We can always fix things in a follow up. QA has signed off (employees can see https://bravesoftware.slack.com/archives/C212VB0RG/p1729802455439579) |
|
Released in v1.73.47 |
emerick
pushed a commit
that referenced
this pull request
Oct 25, 2024
Upgrade from Chromium 130 to Chromium 131.
24 tasks
emerick
pushed a commit
that referenced
this pull request
Oct 25, 2024
Upgrade from Chromium 130 to Chromium 131.
emerick
pushed a commit
that referenced
this pull request
Oct 25, 2024
Upgrade from Chromium 130 to Chromium 131.
emerick
pushed a commit
that referenced
this pull request
Oct 30, 2024
Upgrade from Chromium 130 to Chromium 131.
emerick
pushed a commit
that referenced
this pull request
Oct 30, 2024
Upgrade from Chromium 130 to Chromium 131.
emerick
pushed a commit
that referenced
this pull request
Oct 30, 2024
Upgrade from Chromium 130 to Chromium 131.
kjozwiak
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Upgrade from Chromium 130.0.6723.70 to Chromium 130.0.6723.91 (1.72.x) (#26296) * Upgrade from Chromium 130.0.6723.70 to Chromium 130.0.6723.91 * Update pins list timestamp --------- Co-authored-by: brave-builds <[email protected]> * Merge pull request #25662 from brave/cr131 Upgrade from Chromium 130 to Chromium 131. * Merge pull request #26256 from brave/cr131-followup-fix-extensions-sidebar-styles Migrate extensions sidebar override to use Lit * Merge pull request #26277 from brave/cr131-followup-disable-https-first-balanced-mode Disable HTTPS first balanced mode * Fixed SearchEngineProviderServiceTest.PRE_InvalidPrivateSearchProviderRestoreTest fix brave/brave-browser#41470 TemplateURLService should be loaded before setting prefs::kSyncedDefaultPrivateSearchProviderGUID prefs. * [Android] Fix for crash in Password settings Chromium change: https://source.chromium.org/chromium/chromium/src/+/df77cbacb9476b0b6d3e75cc34b5d127985e79c3 [Settings] Enable the single-activity mode by default Bug: b/356743945 * [Android] Explicitly remove `New tab page cards` from menu This item used in the upstream NTP, that we don't use. --------- Co-authored-by: brave-builds <[email protected]> Co-authored-by: Brian Clifton <[email protected]> Co-authored-by: Simon Hong <[email protected]> Co-authored-by: Artem Samoilenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#41130
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: