Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Swap simulators used for tests to Xcode 16 supported ones (uplift to 1.70.x) #25661

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[iOS] Swap simulators used for tests to Xcode 16 supported ones (uplift to 1.70.x) #25661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/commands/lib/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ const runTests = (passthroughArgs, suite, buildConfig, options) => {

if (config.targetOS === 'ios') {
util.run(path.join(config.outputDir, "iossim"), [
"-d", "\"iPhone 14 Pro\"",
"-d", "\"iPhone 16\"",
path.join(config.outputDir, `${suite}.app`),
path.join(config.outputDir, `${suite}.app/PlugIns/${suite}_module.xctest`)
], config.defaultOptions)
Expand Down
4 changes: 2 additions & 2 deletions ios/brave-ios/fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ platform :ios do
defaultScanParams = scan_params()
run_tests(defaultScanParams.merge!({
test_without_building: true,
devices: ["iPhone 15"],
devices: ["iPhone 16 (18.0)"],
ensure_devices_found: true,
skip_testing: skipped_tests()
}))

run_tests(defaultScanParams.merge!({
test_without_building: true,
devices: ["iPad (10th generation)"],
devices: ["iPad (10th generation) (18.0)"],
ensure_devices_found: true,
output_files: "junit-ipad.xml",
testplan: "Brave_iPad"
Expand Down
Loading