Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nala]: Temporarily override TonalOutline in dark mode #25635

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#41125

Note: This doesn't fix the devtools Clear storage button issue @AlanBreck found - I need to patch devtools for that so I'm going to do that in a separate PR

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@fallaciousreasoning
Copy link
Contributor Author

This should probably be uplifted to 1.71

@fallaciousreasoning fallaciousreasoning merged commit 290afde into master Sep 19, 2024
18 checks passed
@fallaciousreasoning fallaciousreasoning deleted the rorange-focus branch September 19, 2024 07:00
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 19, 2024
brave-builds added a commit that referenced this pull request Sep 19, 2024
fallaciousreasoning pushed a commit that referenced this pull request Sep 23, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Sep 24, 2024

Verification PASSED using

Brave | 1.72.35 Chromium: 129.0.6668.59 (Official Build) nightly (64-bit)
-- | --
Revision | 8cd08e988791e9af165a231677472ffaaa5ae548
OS | Windows 11 Version 23H2 (Build 22631.4169)

Verified using STR from brave/brave-browser#41125 (comment)

Confirmed using dark theme, some of the buttons no longer show an orange ring/outline.

Verified buttons don't show orange/outline in light theme as expected.

dark light
image image
image image
image image

kjozwiak pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some buttons still have orange ring/outline on dark theme
3 participants