[ads] General code health

brave · Nov 7, 2024 · 9f5a7fb · 9f5a7fb
1 parent af6a9f5
commit 9f5a7fb
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/browser/brave_ads/device_id/device_id_impl_unittest.cc b/browser/brave_ads/device_id/device_id_impl_unittest.cc
@@ -14,9 +14,9 @@ namespace brave_ads {
 
 namespace {
 
-struct DisallwedMask {
+struct DisallowedMask {
   template <typename... Args>
-  constexpr DisallwedMask(Args... args)  // NOLINT(runtime/explicit)
+  constexpr DisallowedMask(Args... args)  // NOLINT(runtime/explicit)
       : address{static_cast<uint8_t>(args)...}, size(sizeof...(args)) {}
 
   base::span<const uint8_t> as_span() const {
@@ -27,7 +27,7 @@ struct DisallwedMask {
   size_t size;
 };
 
-void TestDisallowedRange(DisallwedMask mask) {
+void TestDisallowedRange(DisallowedMask mask) {
   std::array<uint8_t, 6u> address;
 
   // test the lower bound of the match

diff --git a/browser/brave_ads/tabs/ads_tab_helper.cc b/browser/brave_ads/tabs/ads_tab_helper.cc
@@ -39,10 +39,10 @@ constexpr int kHttpClientErrorResponseStatusCodeClass = 4;
 constexpr int kHttpServerErrorResponseStatusCodeClass = 5;
 
 constexpr char16_t kSerializeDocumentToStringJavaScript[] =
-    u"new XMLSerializer().serializeToString(document)";
+    U"new XMLSerializer().serializeToString(document)";
 
 constexpr char16_t kDocumentBodyInnerTextJavaScript[] =
-    u"document?.body?.innerText";
+    U"document?.body?.innerText";
 
 std::string MediaPlayerUuid(const content::MediaPlayerId& id) {
   return base::StringPrintf("%d%d%d", id.frame_routing_id.child_id,

diff --git a/browser/brave_ads/tooltips/ads_tooltips_controller.h b/browser/brave_ads/tooltips/ads_tooltips_controller.h
@@ -8,7 +8,6 @@
 
 #include <string>
 
-#include "base/memory/raw_ptr.h"
 #include "brave/browser/ui/brave_tooltips/brave_tooltip_delegate.h"
 #include "brave/components/brave_ads/browser/tooltips/ads_tooltips_delegate.h"
 

diff --git a/components/brave_ads/browser/ads_service.h b/components/brave_ads/browser/ads_service.h
@@ -12,7 +12,6 @@
 #include <string>
 #include <vector>
 
-#include "base/memory/raw_ptr.h"
 #include "base/time/time.h"
 #include "brave/components/brave_ads/browser/ads_service_callback.h"
 #include "brave/components/brave_ads/browser/ads_service_observer.h"