Skip to content

Commit

Permalink
Fix crash on first run on Android
Browse files Browse the repository at this point in the history
  • Loading branch information
mherrmann authored and deeppandya committed Oct 22, 2024
1 parent 35694b8 commit 97e2174
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
10 changes: 10 additions & 0 deletions browser/about_flags.cc
Original file line number Diff line number Diff line change
Expand Up @@ -300,9 +300,18 @@
kOsAndroid, \
FEATURE_VALUE_TYPE(safe_browsing::features::kBraveAndroidSafeBrowsing), \
})
#define BRAVE_DAY_ZERO_EXPERIMENT \
EXPAND_FEATURE_ENTRIES({ \
"brave-day-zero-experiment", \
"Day Zero Experiment", \
"Enables the Day Zero Experiment", \
kOsAndroid, \
FEATURE_VALUE_TYPE(features::kBraveDayZeroExperiment), \
})
#else
#define BRAVE_BACKGROUND_VIDEO_PLAYBACK_ANDROID
#define BRAVE_SAFE_BROWSING_ANDROID
#define BRAVE_DAY_ZERO_EXPERIMENT
#endif // BUILDFLAG(IS_ANDROID)

#if !BUILDFLAG(IS_ANDROID)
Expand Down Expand Up @@ -969,6 +978,7 @@
PLAYLIST_FEATURE_ENTRIES \
BRAVE_COMMANDS_FEATURE_ENTRIES \
BRAVE_BACKGROUND_VIDEO_PLAYBACK_ANDROID \
BRAVE_DAY_ZERO_EXPERIMENT \
BRAVE_SAFE_BROWSING_ANDROID \
BRAVE_CHANGE_ACTIVE_TAB_ON_SCROLL_EVENT_FEATURE_ENTRIES \
BRAVE_TABS_FEATURE_ENTRIES \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include "brave/browser/android/first_run/features.h"
#include "brave/browser/android/preferences/features.h"
#include "brave/browser/android/safe_browsing/features.h"
#include "brave/browser/brave_browser_features.h"
#include "brave/components/ai_chat/core/common/buildflags/buildflags.h"
#include "brave/components/brave_news/common/features.h"
#include "brave/components/brave_rewards/common/features.h"
Expand Down Expand Up @@ -51,7 +52,8 @@
&google_sign_in_permission::features::kBraveGoogleSignInPermission, \
&net::features::kBraveForgetFirstPartyStorage, \
&brave_shields::features::kBraveShowStrictFingerprintingMode, \
&brave_shields::features::kBraveLocalhostAccessPermission
&brave_shields::features::kBraveLocalhostAccessPermission, \
&features::kBraveDayZeroExperiment

// clang-format on

Expand Down

0 comments on commit 97e2174

Please sign in to comment.