Improve method name

brave · Sep 24, 2024 · 34d5425 · 34d5425
1 parent 813481f
commit 34d5425
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/android/java/org/chromium/chrome/browser/firstrun/WelcomeOnboardingActivity.java b/android/java/org/chromium/chrome/browser/firstrun/WelcomeOnboardingActivity.java
@@ -214,7 +214,7 @@ private void onClickViews() {
             mBtnPositive.setOnClickListener(
                     view -> {
                         if (mCurrentStep == 1 && !isDefaultBrowser()) {
-                            setDefaultBrowser();
+                            setDefaultBrowserAndProceedToNextStep();
                         } else {
                             nextOnboardingStep();
                         }
@@ -238,11 +238,12 @@ private boolean shouldForceDefaultBrowserPrompt() {
                         BraveFeatureList.ANDROID_FORCE_DEFAULT_BROWSER_PROMPT);
     }
 
-    private void setDefaultBrowser() {
+    private void setDefaultBrowserAndProceedToNextStep() {
         BraveSetDefaultBrowserUtils.setDefaultBrowser(this);
         if (!BraveSetDefaultBrowserUtils.supportsDefaultRoleManager()) {
             nextOnboardingStep();
         }
+        // onActivityResult will call nextOnboardingStep().
     }
 
     private boolean isDefaultBrowser() {
@@ -296,7 +297,7 @@ public void run() {
             }
         } else if (mCurrentStep == 1) {
             if (shouldForceDefaultBrowserPrompt()) {
-                setDefaultBrowser();
+                setDefaultBrowserAndProceedToNextStep();
             } else {
                 int margin = mIsTablet ? 200 : 30;
                 setLeafAnimation(mVLeafAlignTop, mIvLeafTop, 1.3f, margin, true);