Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Add Source to Brave News' missing from hamburger menu for articles #41208

Closed
2 of 5 tasks
Uni-verse opened this issue Sep 23, 2024 · 2 comments · Fixed by brave/brave-core#25748
Closed
2 of 5 tasks
Assignees
Labels

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 23, 2024

Description

'Add Source to Brave News' missing from hamburger menu for articles

Regression in 1.71

Steps to reproduce

  1. New Install
  2. Enable Brave News
  3. Navigate to https://en.wikipedia.org/wiki/Main_Page or an article
  4. Scroll down the article half way
  5. Open hamburger menu, look for Add Source to Brave News in the share menu

Actual result

Option is missing from menu

IMG_7446

Expected result

IMG_7447

Reproduces how often

Easily reproduced

Brave version

1.70 - Not reproducible
1.71 - Reproducible
1.72 - Reproducible

Device/iOS version

iPhone / iOS 18

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@LaurenWags
Copy link
Member

Requires 1.71.105 or higher for verification 👍🏻

@Uni-verse
Copy link
Contributor Author

Uni-verse commented Oct 17, 2024

Verified on iPhone 12 running iOS 18 using version 1.71.112

  • Ensured that Add Source to Brave News is shown in the hamburger shared menu for news articles.
  • Ensured that sources can be added using Add Source to Brave News and shows up in the Following list in Brave News settings.
example example example
Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants