Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add japanese translations, styling and bug fixes for contributions page #4503

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

jlbyrne
Copy link
Contributor

@jlbyrne jlbyrne commented Sep 17, 2024

  • fixes gemini icon
  • fixes mobile image uploader
  • adjusts social link icons to remove darker background
  • adds japanese translations
  • fixes a bug where visiting the public channel page breaks if a creator doesn't have a SiteBanner already created for their channel
  • updates dependencies
  • removes 'clear social link' option when no social link has been selected

@jlbyrne jlbyrne force-pushed the fix/translations-contribution-pages branch from 262f9d3 to f60cdf3 Compare September 18, 2024 16:10
Copy link
Collaborator

@DJAndries DJAndries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jlbyrne jlbyrne force-pushed the fix/translations-contribution-pages branch from f60cdf3 to 20cce06 Compare September 18, 2024 16:56
Copy link

The following commits were not verified:
20cce06 (unsigned)

@jlbyrne jlbyrne merged commit ca1a982 into staging Sep 18, 2024
7 checks passed
@jlbyrne jlbyrne deleted the fix/translations-contribution-pages branch September 18, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants