Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of typo in image upload and unnecessary file extensions #4502

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

jlbyrne
Copy link
Contributor

@jlbyrne jlbyrne commented Sep 12, 2024

gets rid of additional . character in the content type, gets rid of the .padded extension in the filename, and removes .jpg.pad from the s3 request.

Yarn updates are the result of running yarn-audit-fix.

Copy link

The following commits were not verified:
d9bf523 (unsigned)

@porteron porteron self-requested a review September 13, 2024 17:17
Copy link
Member

@porteron porteron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine to me, but we should get more information on the purposes of having padded images here before merging.

@jlbyrne jlbyrne merged commit 2fc5214 into staging Sep 16, 2024
7 checks passed
@jlbyrne jlbyrne deleted the fix/pcdn-image-issues branch September 16, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants