Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove piwik #4471

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Remove piwik #4471

merged 5 commits into from
Jul 10, 2024

Conversation

tsmartt
Copy link
Contributor

@tsmartt tsmartt commented Jul 9, 2024

@tsmartt tsmartt requested a review from jlbyrne July 9, 2024 14:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

[puLL-Merge] - brave-intl/publishers@4471

Description

This PR removes Piwik analytics integration from the Brave Publishers application. It removes all Piwik-related attributes, configuration, and JavaScript code.

Changes

Changes

  1. app/helpers/application_helper.rb:

    • Removed the piwik_domain method.

  2. app/javascript/analytics.js:

    • Deleted the entire file which contained Piwik-related JavaScript code.

  3. Multiple view files:

    • Removed data-piwik-* attributes from HTML elements.
    • Removed data-piwik-host attribute from <head> tags.

  4. app/views/layouts/application.html.slim and other layout files:

    • Removed data-piwik-host attribute from <head> tag.

  5. config/secrets.yml:

    • Removed Piwik-related configuration variables:
      • piwik_host
      • piwik_token
      • piwik_host_prefix

Possible Issues

  1. Loss of analytics data: By removing Piwik integration, the application will no longer collect analytics data, which might impact decision-making and user behavior analysis.

  2. Broken dependencies: If any part of the application relied on Piwik data or integration, those features may now be broken or non-functional.

Security Hotspots

There are no significant security hotspots in this change. In fact, removing analytics tracking can be seen as a privacy improvement for users.

@tsmartt tsmartt merged commit 6627265 into staging Jul 10, 2024
7 checks passed
@tsmartt tsmartt deleted the fix/remove-piwik branch July 10, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlbyrne jlbyrne jlbyrne approved these changes

Assignees
No one assigned
Labels
puLL-Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsmartt @jlbyrne