Skip to content

Commit

Permalink
update node
Browse files Browse the repository at this point in the history
  • Loading branch information
jlbyrne committed Oct 22, 2024
1 parent 068d3de commit 063512b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.17.0
20.18.0
2 changes: 1 addition & 1 deletion Dockerfile.dev
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ RUN gem install nokogiri
RUN bundle install --jobs 20

ENV NVM_DIR /usr/local/nvm
ENV NODE_VERSION 18.17.0
ENV NODE_VERSION 20.18.0
ENV NODE_OPTIONS=--openssl-legacy-provider
ENV NODE_PATH $NVM_DIR/versions/node/v$NODE_VERSION/lib/node_modules
ENV PATH $NVM_DIR/versions/node/v$NODE_VERSION/bin:$PATH
Expand Down
2 changes: 1 addition & 1 deletion nextjs/.npmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.17.0
v20.18.0
6 changes: 3 additions & 3 deletions nextjs/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Install dependencies only when needed
FROM node:18-alpine AS deps
FROM node:20-alpine AS deps
# Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed.
RUN apk add --no-cache libc6-compat
WORKDIR /app
Expand All @@ -8,7 +8,7 @@ COPY package.json package-lock.json* ./
RUN npm i

# Rebuild the source code only when needed
FROM node:18-alpine AS builder
FROM node:20-alpine AS builder
WORKDIR /app
COPY --from=deps /app/node_modules ./node_modules
COPY . .
Expand All @@ -24,7 +24,7 @@ ENV NEXT_TELEMETRY_DISABLED 1
RUN npm run build

# Production image, copy all the files and run next
#FROM node:18 AS runner
#FROM node:20 AS runner
#WORKDIR /app
# RUN npm run build
# ENV NODE_ENV production
Expand Down

0 comments on commit 063512b

Please sign in to comment.