Fix minor clippy warnings #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address a clippy warning by unpacking over the container elements directly instead of using a range and index variable. This is more idiomatic.
Use the more explicit `is_err` instead of negating `is_ok`. Addresses a clippy lint.
Address a clippy warning. When the struct initialization value has the same name as the member, it's idiomatic to omit the member label.
The base64 package is referred to by its full path, so the explict `use` statement is redundant in contemporary rust compilers. Addresses a clippy lint.
evq
approved these changes
Dec 13, 2023
evq
added a commit
that referenced
this pull request
Jun 20, 2024
* Update deps, 2.0.0 release * Fix minor clippy warnings (#38) * Loop over test vectors directly Address a clippy warning by unpacking over the container elements directly instead of using a range and index variable. This is more idiomatic. * Simplify test assertion Use the more explicit `is_err` instead of negating `is_ok`. Addresses a clippy lint. * Remove redundant struct label in test Address a clippy warning. When the struct initialization value has the same name as the member, it's idiomatic to omit the member label. * Remove unnecessary base64 import The base64 package is referred to by its full path, so the explict `use` statement is redundant in contemporary rust compilers. Addresses a clippy lint. * Fix broken build status badge (#37) The travis-ci.org service is no longer available. Link to the github actions status badge and page instead. * Update to criterion 0.5 (#36) * Update to criterion 0.5 Use the latest release of the `criterion` benchmark framework, v0.5.1 at the time of writing. No relevant api changes. This aligns with more recent software releases so there's less surprise and fewer old versions of things. * Fix benchmark typo Correct spelling of the "sign pre-tokens" benchmark. * cargo fmt (#39) --------- Co-authored-by: Ralph Giles <[email protected]> Co-authored-by: Ralph Giles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address clippy lints on the test code
useimportThis addresses everything in
cargo clippy --all-targetsunder rust 1.74.1, except for the unused function inbenchmark.rs. Changes will conflict with similar fixes in #33.