-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update expired certificates #2701
Conversation
When I ran the grants container I got these errors: > DBG failed to dial: x509: certificate has expired or is not yet valid: current time 2024-10-29T18:07:57Z is after 2024-04-02T16:18:51Z module=kafka.NewKafkaReader > DBG Unable to establish connection to consumer group coordinator for group grant-bat-skus-local: failed to dial: x509: certificate has expired or is not yet valid: current time 2024-10-29T18:08:02Z is after 2024-04-02T16:18:51Z module=kafka.NewKafkaReader > DBG failed to dial: x509: certificate has expired or is not yet valid: current time 2024-10-29T18:08:02Z is after 2024-04-02T16:18:51Z module=kafka.NewKafkaReader I verified that the certificates were expired: ``` $ openssl x509 -in test/secrets/snakeoil-ca-1.crt -noout -text | grep 'Not' Not Before: Apr 3 16:18:51 2023 GMT Not After : Apr 2 16:18:51 2024 GMT ``` To regenerate the certificates I used `test/secrets/README.md`
pG3Y+OzBK0O4VaTM5A+z7zH49FJqeHnPlvixMRlpQ0OFtDWQ6suS2QJAdZm6k1cV | ||
rO3D7HybiU+2H13q7lRc9CUgy9fHMyowU+Ab5nONiZQat4e4G9mG3vC3hCqGl7uK | ||
xtPMeens4rlu1Q== | ||
MIICdgIBADANBgkqhkiG9w0BAQEFAASCAmAwggJcAgEAAoGBAKhWPvrwCl+o74i2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] Private Key detected. This is a sensitive credential and should not be hardcoded here. Instead, store this in a separate, private file.
Source: https://semgrep.dev/r/generic.secrets.security.detected-private-key.detected-private-key
Cc @thypon @kdenhartog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test keys and already in the repo and using a script to be generated
18LOCPjsAUI7g10mCw9n/+nqOXPAYKy7HhDWRxfH2YKmfBln77MEalwtNS9o2NOi | ||
ymoOVH0kfhRmRNzS06zWHS+jYzlgVVod3zZ6VfmzFm2D/mkqjkTRtOiUkkoBzgLc | ||
dC0iOYfxJXHSpPlK/fTFCQ== | ||
MIIFJDBWBgkqhkiG9w0BBQ0wSTAxBgkqhkiG9w0BBQwwJAQQaYTaCPcySarxocpD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] Private Key detected. This is a sensitive credential and should not be hardcoded here. Instead, store this in a separate, private file.
Source: https://semgrep.dev/r/generic.secrets.security.detected-private-key.detected-private-key
Cc @thypon @kdenhartog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test keys and already in the repo and using a script to be generated
These certs are for testing, not concerned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM approved.
[puLL-Merge] - brave-intl/bat-go@2701 DescriptionThis PR updates various certificates and keys used for testing purposes in the ChangesChanges
These changes appear to be routine updates to test certificates and keys, likely to ensure they remain valid for ongoing testing purposes. |
Summary
When I ran the grants container I got these errors:
I verified that the certificates were expired:
To regenerate the certificates I used
test/secrets/README.md
Type of Change
Tested Environments
Before Requesting Review
Not applicable:
Manual Test Plan