Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use leo annual issuer if redemption fails for regular leo #2647

Merged
merged 2 commits into from
Aug 26, 2024
Merged

fix: use leo annual issuer if redemption fails for regular leo #2647

merged 2 commits into from
Aug 26, 2024

Conversation

pavelbrm
Copy link
Contributor

Summary

If redemption failed for regular Leo because of the wrong issuer, try requesting it with the annual.

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@pavelbrm pavelbrm self-assigned this Aug 26, 2024
evq
evq requested changes Aug 26, 2024
View reviewed changes
services/skus/service.go Outdated Show resolved Hide resolved
@pavelbrm pavelbrm requested a review from evq August 26, 2024 05:53
@pavelbrm pavelbrm requested review from evq and removed request for evq August 26, 2024 06:54
@pavelbrm pavelbrm merged commit a9fc2ea into master Aug 26, 2024
12 checks passed
@pavelbrm pavelbrm deleted the fix-leo-redemption branch August 26, 2024 07:07
@pavelbrm pavelbrm mentioned this pull request Aug 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 26, 2024
@pavelbrm
Merge pull request #2648 from brave-intl/master
cd5f926 
fix: use leo annual issuer if redemption fails for regular leo (#2647)
@evq evq mentioned this pull request Aug 26, 2024
Open
@pavelbrm pavelbrm mentioned this pull request Nov 11, 2024
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clD11 clD11 clD11 approved these changes

@evq evq evq approved these changes

Assignees

@pavelbrm pavelbrm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelbrm @evq @clD11