Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tlv2 idempotency: check both credential and request id #2643

Closed
wants to merge 1 commit into from
Closed

tlv2 idempotency: check both credential and request id #2643

wants to merge 1 commit into from

Conversation

evq
Copy link
Contributor

@evq evq commented Aug 21, 2024

Summary

should make the query a little more efficient

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@evq
tlv2 idempotency: check both credential and request id
7f83079 
should make the query a little more efficient
@evq evq requested a review from pavelbrm August 21, 2024 23:39
@pavelbrm
Copy link
Contributor

Closing this because it's been superseded by #2644.

@pavelbrm pavelbrm closed this Aug 22, 2024
@pavelbrm pavelbrm deleted the tlv2-submission-report-query-tweak branch August 22, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelbrm pavelbrm Awaiting requested review from pavelbrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evq @pavelbrm