Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LookupVerifier returns interface (#2631) #2632

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

ibukanov
Copy link
Collaborator

@ibukanov ibukanov commented Aug 5, 2024

Fix the signature of the LookupVerifier method of the Keystore interface to return Verifier interface directly, not a pointer to it to simplify implementations of the method.

Summary

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

Fix the signature of the LookupVerifier method of the Keystore interface
to return Verifier interface directly, not a pointer to it.
@ibukanov ibukanov requested a review from pavelbrm August 5, 2024 14:25
@pavelbrm pavelbrm requested a review from clD11 August 6, 2024 08:24
@pavelbrm
Copy link
Contributor

pavelbrm commented Aug 6, 2024

Also tagged @clD11 for the Wallet service.

Copy link
Contributor

@pavelbrm pavelbrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason it was needed to be done that way. Pointers to interfaces are sometimes needed and useful (like keeping a set of them), but in this particular case it seem more like a mistake.

Approving. It would be nice to get one from @clD11 as well.

@ibukanov ibukanov merged commit 9943700 into master Aug 7, 2024
12 checks passed
@ibukanov ibukanov deleted the igor/2631/LookupVerifier branch August 7, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants